Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

Spencer 80

@Divinitry

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

proud of

  • finished it and turned out how as expected
  • better usage of width and max-width
  • feeling good with continuing with other projects on here

What challenges did you encounter, and how did you overcome them?

issue with responsive design, fixed it by doing width and max-width and not overcomplicating the design with media queries

What specific areas of your project would you like help with?

css, maybe there are redundant areas? best practices for css? responsive design tips for CSS fonts.

Community feedback

MikDra1 6,070

@MikDra1

Posted

Nice one @Spencer

If you want to get your font-sizes responsive you should use the clamp() method. If you don't know it here is VIDEO about it.

If you find this comment useful please mark it as helpful 💗

Good job and keep going 😁😊😉

Marked as helpful

0
Alex 3,130

@Alex-Archer-I

Posted

Hey!

Congrats with your first challenge =)

I suggest you to use less divs and more semantic tags =) There aren't much tags here, but at least it could be h1 tag for main text and p for the second.

As for css you really did it well. I can only recommend you to use min-height instead height for body tag - just in case if the content would be lager than the screen. Also you can omit height: auto of the image cos it is a default value.

Hope that helps a bit. Keep doing cool stuff =)

Marked as helpful

0

Spencer 80

@Divinitry

Posted

@Alex-Archer-I

Thank you for the feedback Alex! Will implement these into my future projects!

1
Alex 3,130

@Alex-Archer-I

Posted

@Divinitry

You're welcome. Fell free to ask, comment and stuff if you need =)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord