QR code component

Hello,

Great effort on your code! I noticed that the image isn't displaying properly, and it might be due to an issue with the file path. Take a moment to double-check the path for your image. Making sure it's accurate will undoubtedly enhance the visual appeal of your project.

Keep up the good work.

Hello there 👋. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

HTML 🏷️:

• Use semantic elements such as <main> and <footer> to improve accessibility and organization of your page.

• The <br> tag is often used to create line breaks, but it doesn't convey any semantic meaning. When a screen-reader reads the text, it will break the flow of reading at the line break tag, which can be confusing for users. More information here.

• Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

CSS 🎨:

• Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource 📘.

CSS Reset 🔄:

• You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.

  CSS resets that are widely used:

  • Reset CSS
  • "My Custom CSS Reset" by JoshWComeau

I hope you find it useful! 😄

Happy coding!

Hello @Cassio-Master!

Your solution looks great!

But your missing the QR Code image. That's because you set the incorrect path for the image. Here's your code:

 <img src="/novato/qr-code-component-main/images/image-qr-code.png" width="270px" height="260px">

To fix it, you can do this:

<img src="./images/image-qr-code.png" width="270px" height="260px">

• Also, I noticed that you used position to center the card. Here's a very efficient way to place it in the middle of the page:

You can apply this to the body (in order to work properly, you can't use position or margins):

body {
    min-height: 100vh;
    display: flex;
    justify-content: center;
    align-items: center;
}

I hope it helps!

Eu sei que comete muitos erros pós digo que eu sou novato vocês não sabem o quanto seus comentários estão me ajudando obrigado por todos