QR code component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi McMuffin, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • add descriptive text in the alt attribute of the image
  • set min-heigth: 100vh to body because Flexbox aligns items to the size of the parent container
  • instead of using px try to use relative units of measurement -> read here

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  0

  ---

  

  McMuffin1022•30

  @McMuffin1022Posted over 2 years ago

  @denielden thank you for your constructive comment! These are points I hadn't thought of. I will look into improving the qr code.

  Thanks and have fun with your coding :)

  1
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey McMuffin1022, good job with this challenge. Your solution looks seemingly close to the design however I think your text needs to be within the card so simply change the width of the text like this width: fit-content.

  In terms of your accessibility issue, wrapping all your content between <main> tags should help.

  I hope this helps

  Cheers, Happy coding 👍

  Marked as helpful

  0

  ---

  

  McMuffin1022•30

  @McMuffin1022Posted over 2 years ago

  @TheCoderGuru Thanks men! Indeed, it would solve my current problems.

  Thanks for your time and have fun with your coding too!

  1