QR Code Solution

Community feedback

• 

  Adriano•38,120

  @AdrianoEscarabotePosted almost 2 years ago

  Hello Gilbert Ofori-Boye, how are you? Welcome to the community of front-end mentors! I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

  A document ought to have one primary landmark, and the absence of a main tag around the page's primary content is the root of this issue. On this page, there is no other element that is more important than the one that this challenge is based on, so to solve it, wrap all the content in the'main' tag.

  It's always a good idea to pay close attention to the proper use of semantic html elements because they are crucial for screen reader users to understand what the main content of the page is in the case of the'main' tag!

  avoid using px, If your web content font sizes are set to absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. if you want to keep using px for development and then format the whole code to rem, you can use this vscode extension: px to rem

  The remainder is excellent.

  I hope it's useful. 👍

  Marked as helpful

  0
• 

  Gilbert Ofori-Boye•90

  @GilbertWalkerPosted almost 2 years ago

  Thank you so much Adriano, I have actually done wrapping the whole content in a main tag with the role as main. I would also want to know more on the landmarks if you could help. i love the extension too, its going to really help.

  With going forward can you also explain little to me about flex and grid i had difficulty with which to use.

  0