QR code component

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted over 2 years ago

  Hey there,

  Your solution looks good! There's only one issue here: you're setting height to so many of your elements. This isn't needed most of the time. Elements have their own height by default, which you should only increase by adding some padding/margin. There are a few places really when setting height is needed: you can set a min-height: 100% on the body or container div, and a height: auto on images (you set 100% on it, but auto would be better, as this way the aspect-ratio of the image is kept even if the image isn't a perfect square).

  To answer your question: every time you update the code, Github Pages needs to update your websites and well, this just takes time. From my own experience, Github Pages is slower than some other hosting solutions, so at some point you may wanna switch to something faster (like Netlify) if this bothers you. I wouldn't worry too much about this though if you're just starting out with web development. ^^

  Marked as helpful

  0

  ---

  

  Ha Anna•20

  @its-haannaPosted over 2 years ago

  @FluffyKas Thank you so much for such a detailed answer! I will try following your advice! ^^

  0