QR CODE COMPONENT

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have some recommendations regarding your code that I believe will be of great interest to you.

  CSS 🎨:

  • let me explain, How you can easily center the component.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  
      margin: 0;
  }
  

  • Now remove this styles, after removing you can able to see the changes

  .container {
      margin-top: 80px;
  }
  

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Darlington Adusei•80

  @DarlenequamePosted over 1 year ago

  @0xAbdulKhalid Thank you for your recommendations and link to resource. I applied suggestions and it worked as stated. Thank you

  0
• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hey there,

  congrats on completing the challenge successfully! Your submission looks pretty nice overall. It looks like you have a very bright value for the <p> text, which makes it hard to read then the background is also very bright. I would suggest using a darker font color so it has enough contrast with the background and improve readability.

  Hope you find this feedback helpful!

  1