Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR CODE COMPONENT

@Darlenequame

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I still have much to learn on using flexbox. Kindly share any advice and recommendations.

Community feedback

Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have some recommendations regarding your code that I believe will be of great interest to you.

CSS 🎨:

  • let me explain, How you can easily center the component.
  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states
  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here πŸ“š.
  • For this demonstration we use css Grid to center the component
body {
    min-height: 100vh;
    display: grid;
    place-items: center;

    margin: 0;
}
  • Now remove this styles, after removing you can able to see the changes
.container {
    margin-top: 80px;
}

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1

@Darlenequame

Posted

@0xAbdulKhalid Thank you for your recommendations and link to resource. I applied suggestions and it worked as stated. Thank you

0
P
visualdennisβ€’ 8,375

@visualdenniss

Posted

Hey there,

congrats on completing the challenge successfully! Your submission looks pretty nice overall. It looks like you have a very bright value for the <p> text, which makes it hard to read then the background is also very bright. I would suggest using a darker font color so it has enough contrast with the background and improve readability.

Hope you find this feedback helpful!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord