QR-code-component using flex

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

  Answering your question:

  • You should use a CSS reset to remove the default browser styles and make your page look the same in all browsers.

  Your body's default margin causes the vertical scrollbar to appear.

  Popular CSS resets:

  • Normalize.css
  • Reset CSS

  HTML:

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding! 🎄

  Marked as helpful

  0
• 

  Derwing Medina•200

  @derwingPosted almost 2 years ago

  You have many ways to hiding the scroll - this is one, set the min-height to 90vh

  main {
      min-height: 90vh;
  }
  

  Marked as helpful

  0

  ---

  

  Beatrice•30

  @bettywangaPosted almost 2 years ago

  @derwing This worked!

  0