Design comparison
SolutionDesign
Community feedback
- @denieldenPosted almost 2 years ago
Hello Trung, You have done a good work! 😁
Some little tips to improve your code:
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - add descriptive text in the
alt
attribute of the images - remove all unnecessary code, the less you write the better as well as being clearer: for example the
div
container of image - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful1@TLBTrung-222Posted almost 2 years ago@denielden many thanks sir, I will improve it for the later projects.
1@denieldenPosted almost 2 years ago@TLBTrung-222 you are welcome and keep it up :)
1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord