Design comparison
SolutionDesign
Community feedback
- @denieldenPosted almost 2 years ago
Hello Anima, You have done a good work! 😁
Some little tips to improve your code:
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - add descriptive text in the
alt
attribute of the images - use
min-height: 100vh
to.container
class instead ofheight
, otherwise the content is cut off when the browser height is less than the content - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful0@aimaduddinPosted almost 2 years ago@denielden
Hello Deniel. It's "Aima", not "Anima" 😂
Anyways, thank you so much for taking the time to read my code and give some feedback. I'm very new to the CSS world and will try to improve my code based on your comments.
Stay safe and happy coding too! 😎
1@denieldenPosted almost 2 years ago@aimaduddin Sorry for the typo 😂 you are welcome and keep it up :)
0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord