QR CODE COMPONENT

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div id="container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Osasuyi Osawe•10

  @DoubleOWebDevPosted over 1 year ago

  @0xAbdulKhalid

  Thank you for the reply!

  0
• 

  TreNyceCodes•230

  @TrenyceCodesPosted over 1 year ago

  Good Job on creating and finishing your first frontend mentor post

  The code you posted is good but here are some changes you can make to have it more readable.

  • You can have one CSS file that is connected to your HTML file*
  • You can add the root pseudo-class to your CSS to keep all your color hsl, hexes, or rgb well structured. You can check that out here css-root-pseudo-class.
  • look at others' codes to get an understanding of the problems. Don't copy and paste because you won't learn properly
  • if you are not using the HTML elements in your HTML file, don't add them to the CSS file. This can cause a confusing and big disorganizing mess.
  • give your HTML elements ids, and classes, and use that in your CSS file.

  I hope this feedback helps. Good job on finishing your first frontend mentor post

  Marked as helpful

  1

  ---

  

  Osasuyi Osawe•10

  @DoubleOWebDevPosted over 1 year ago

  @Neice76

  Thank you and will make the changes!

  1

  

  TreNyceCodes•230

  @TrenyceCodesPosted over 1 year ago

  @DoubleOWebDev you’re welcome. Good job on your project.

  Happy Coding!

  0