Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

@Gabriel-Leao

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello community, I'm Gabriel Lion and this is my qr code component solution. if there's anything I can improve, please help me. Thanks

Community feedback

Rio Cantre 9,690

@RioCantre

Posted

Hello there! Good job in this challenge. Viewing the solution, I think you should consider the following as well…

  • Instead of a div, alternatively wrap the content with a main tag . Use semantic tag, for HTML structures, refer it with this one Semantics
  • Remove height: 68vh; in .qrcode-conteudo rule set. Add padding: 1rem;
  • Remove height: 250px; and adjust width into width: 100%; in .img-principal rule set
  • Add margin-top: 0; in the .text rule set
  • Add padding: 1rem; in the attribution rule set

Above all, Well done! Keep it up and Hope this is helpful!

Marked as helpful

0

Account Deleted

Hello there! 👋

Congratulations on finishing your challenge! 🎉

I have some feedback on this solution:

  • Always Use Semantic HTML instead of div like <main> <header> <footer> , etc for more info

  • reduce the height of the qr-code to 50vh

i hope this is helpful and goodluck!

Marked as helpful

0

@optimusprime202

Posted

Hey @Gabriel-Leao, I like this.

0
Naveen Gumaste 10,460

@NaveenGumaste

Posted

Hay ! Gabriel Good Job on challenge

These below mentioned tricks will help you remove any Accessibility Issues

-> Add Main tag after body <main class="container"></main>

-> Learn more on accessibility issues

If this comment helps you then pls mark it as helpful!

Have a good day and keep coding 👍!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord