QR code component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  • Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Tales Ribeiro Oliveira•50

  @oliveiratalesPosted over 1 year ago

  Hello Melvin,

  Thank you for the tips, already change the tags "alt" and "min-height" in the project, and I will use it for my next projects.

  Best regards, Tales.

  0
• 

  Super Oleksandr•320

  @super-simonPosted over 1 year ago

  Hello!

  My advice is to make layout of the blue square with circles, and insert only the QR code as an image. In real project, back-end will generate a QR code without background.

  1

  ---

  

  Elizabeth Salako•10

  @LizCodeStoriesPosted over 1 year ago

  @super-simon

  Hi!

  And thank you for your helpful advice :)

  1