@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- The
width: 100vw
property in thebody
tag is not necessary. This will create a horizontal scrollbar on some devices.
- The simplest way to set the height of the body element is with
min-height: 100vh
, setting the height to 100vh on the body element can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.
- Tip: The
lang
attribute is used to specify the natural language of the content of an HTML element. This information is used by browsers and assistive technologies, such as screen readers, to adjust their settings and behavior to better suit the content of the page. If the lang attribute is set to pt-BR (Brazilian Portuguese) but the content of the page is in English, screen readers may use Brazilian Portuguese pronunciation rules when reading the English text, which can make it difficult for users to understand.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@Guilherme-Goncalves-de-Souza
Posted
Thank you very much for the feedbacks, I've arranged everyone in my code and i'll use this in my next projects.
Thank you very much @MelvinAguilar !