QR code component

Community feedback

• 

  Marius Bareanu•60

  @MariusSB-codePosted almost 2 years ago

  it looks good, also you cand declare the css with "styles.css" not index :), in other words, continue what you are doing :) like, practice make`s perfect

  Marked as helpful

  1
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div id="container"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center #container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center #container on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center #container on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Increase the width of #container for it to be equivalent to the width of the design and there is no need to give it margin values. e.g.width:320px .

  Give the img a max-width of 100% instead of a width and a height and a border-radius, the rest are not needed. There is no need to give .card a border value.

  Give .details a margin value for all the sides and font size of 15px, this will be the font-size for both p and h1. Give p a margin-top value for the space between the text.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0