Semantic HTML5 markup CSS custom properties Flexbox CSS Grid Mobile-fi

Community feedback

• 

  Rostyslav Nazarenko•560

  @rostyslav-nazarenkoPosted almost 2 years ago

  Hi! Cool code!

  I have a few suggestions.

  • HTML
    • use main element for accessibility. Change <div class="container">...</div> to <main class="container">...</main>
    • alt attribute should describe an image or its function. Don't use the word image because screen readers read the tag as "image". In this case use QR code to frontendmentor.io. Read this article for more information
    • use h1 instead of h2, don't skip levels
  • CSS
    • use relative units to make your solution accessible
    • set max-width: 100% on images

  Hope I've been helpful!

  0