QR code component

Community feedback

• 

  Hassia Issah•50,590

  @HassiaiPosted about 2 years ago

  Replace<div class="container">with the main tag, <p class="fs-700"> with <h1> to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/ Add alt attribute alt=" " to the img tag <img> to fix the error issues. the value of the alt is the description of the image.

  Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

  There is no to give .container a height value and overflow: hidden. Give the img a max-width of 100% instead of a width value. Give .container and .text-container a padding value for all the sides and give p a margin-top value for the space between the text. There is no need for display: flex; and its properties in .text-container and .image container.

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1