Skip to content
Submitted about 2 years ago

QR code component

Luis Alfredo•120
@luiis-fuenmayor
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted about 2 years ago

    Hi @luiis-fuenmayor 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

    Here are some suggestions you might consider:

    • The container isn't centered correctly. You can use flexbox to center elements:
    body {
  width: 100%;
  min-height: 100vh;
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;

   background-color: var(--Light-gray);
    /* height: 666px; */
    /* width: 366px; */
    /* margin: auto; */
    /* padding-top: 85px; */
}

.container {
   . . .
    /* margin: auto; */
    /* position: relative; */
}

    Links with more information:

    .

    With semantic tags:

    <body>
   <main class="container">
      . . .
   </main>
   <footer class="footer">
      . . .
   </footer>
<body>
    • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
    • Add an h1 tag to your solution. The <h1> element is the main heading on a web page. There should only be one <h1> tag per page, and always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference)

    Solution:

    <h1>Improve your front-end skills by building projects</h1>

    I hope those tips will help you.

    Good job, and happy coding!

    Marked as helpful
    0
    Luis Alfredo•120
    @luiis-fuenmayorPosted about 2 years ago

    @MelvinAguilar Ok ok, thank you very much for your help, I'm starting with this and I like that you correct me and give me advice to learn better. Thank you.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord