Simple QR Code Card - Tested to be responsive with over 40 devices.

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

  It is a very organized code :)

  HTML:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  If you want to learn more about the alt attribute, you can read this article.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Open World Project•80

  @OpenWorldProjectOWPPosted almost 2 years ago

  @MelvinAguilar Wonderful feedback! I actually didn't think about that with the "alt" attribute so that is really useful. I'll make some changes! I can't believe I forgot to use <main>! That's exactly why I've been trying to work on semantics lately! Thank you so much Melvin. :)

  1

  

  Open World Project•80

  @OpenWorldProjectOWPPosted almost 2 years ago

  @MelvinAguilar Those changes have been pushed through! Thanks again!

  1