Design comparison
Solution retrospective
I am proud of this result
What challenges did you encounter, and how did you overcome them?I think, I didn;t encounter any challenges
What specific areas of your project would you like help with?None.
Community feedback
- @correlucasPosted about 2 years ago
👾Hi @kingergem, congratulations on your solution!
Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:
1.The main heading has the tag
<h2>, in this case, you should replace it with<h1>since this heading is the main title on this page. Remember that every page should have one<h1>to declare which is the most important title and that you should follow the hierarchy using the heading sequence(h1, h2, h3, h4, h5)and never jump a level.2.The HTML structure is fine and works, and you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary
<div>. For this solution you wrap everything inside a single block of content using<div>or<main>(better option for accessibility) and put inside the whole content<img>/<h1>and<p>.<body> <main> <img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" > <h1>Improve your front-end skills by building projects</h1> <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </main> </body>Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR
✌️ I hope this helps you and happy coding!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord