Submitted almost 2 years ago
html5 and css3, in this project I used the basic html and css to devel
@carlosbarros723
Design comparison
SolutionDesign
Solution retrospective
Hello, I wanted an opinion on how I can improve my techniques in css.
Thank you very much in advance.
Community feedback
- @JAsaxonPosted almost 2 years ago
It looks great! However the text color needs to be adjusted to the ones provided as well as the font size. In the code sector there are some small issues that I found:
- I see that you used a media query, although it works great it is not really necessary as no changes need to be made on smaller devices
- Also It is preferred to use a standardized capitalization system for the class names, I would recommend either hyphenated or camel case
- Adding a class to the body element may be a bit confusing and redundant, It would be preferable to simply use the tag selector for the body
- On the subject of classes not everything needs a class! Remember that you can use child selectors like so ".container > img" as it makes it more reusable
Overall great work!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord