Qr code with flex-box

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Figure elements (<figure>) should only be used when captions are required with <figcaption>, you can directly use the div tag in this solution.

  CSS 🎨:

  • The only background that should be part of the solution is the blue background, the white part is not necessary, it's just a nice way to show a preview of the solution.

  • Setting the width of the card component with a percentage or a viewport unit will behave strangely on mobile devices or large screens. You should use a max-width of 320px or 20rem to make sure that the component will have a maximum width of 320px on any device, also remove the width property with a vw value.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  0