QR-Code page using HTML and CSS

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  There is no need for <div class="background"> in the html and its styling in the css, give its background-color to the body. Replace <div class="container"> with the main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  For a responsive content, there is no need for a height value in .container, replace it with a padding value for all the sides, reduce the width of .container for it to be equivalent to the width of the design. e.g width:320px; padding: 15px. Give the img a max-width of 100% and .text-box a margin value for all the sides instead of a width. margin: 15px

  Give p and h1 the same font-size of 15px. give p a margin-top value for the space between the text.

  To center .container on the page using flexbox, add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Mike•40

  @Mike-is-codingPosted almost 2 years ago

  @Hassiai Thank you very much that was very informative! I will be sure to use this information to make this and future projects better.

  1
• 

  Ahmed Mahrous•980

  @AhmedMahroussPosted almost 2 years ago

  good jop my bro Congrats on completing your challenge!🎊🍻If you have any questions or need further clarification, feel free to reach out to me. Happy Coding! 🎆🎊

  0