QR code component

Community feedback

• 

  T

  Grace•31,090

  @grace-snowPosted almost 2 years ago

  Hello

  As well as the viewport meta tag issue I raised on slack, you need to

  1. Use max width not width on the card
  2. Write the alt text properly. Look up how and when to use that attribute correctly
  3. Stop using complex css selectors like you're doing here. It will become completely unmanageable on larger projects. Instead use single class selectors, keeping css specificity as low as possible
  4. You should not be using the figure element unless content requires a caption
  5. The card should have padding. Elements inside it can have vertical margins
  6. Line height is usually unitless. It's quite unusual to see it written as rem (but not "wrong")
  7. You are misusing the section element. You don't need any element at all wrapping the heading and paragraph in this case, but even if you did it would be a div not section.

  Marked as helpful

  2

  ---

  

  Fathima Nuha•30

  @Fathima-NuhaPosted almost 2 years ago

  @grace-snow could you help me with thosee complex css selectors you mentioned. pls mention them for me.

  0

  

  T

  Grace•31,090

  @grace-snowPosted almost 2 years ago

  @Fathima-Nuha you need to fix the html first.

  Then put classes on what you want to style. Don’t use complex selectors unnecessarily like element > direct-child-element. Instead put a class on what you want to style.

  Read about css specificity and you’ll start to understand why

  Marked as helpful

  1