Vanza Setia• 27,795
@vanzasetia
Posted
Hi, Jhan Galvis! 👋
There's no need to use picture element if there's only one version for the image. You only need to use picture element when there are many versions for the same image (e.g. three versions of image, mobile, tablet, and desktop).
Other than that, everything is looking good as far as the HTML is.
For the styling, I recommend setting min-height: 100vh instead of min-height: 50rem. This way, the body is always filling the entire page regardless of the user's screen size.
I hope this helps! Keep up the good work! 👍
Marked as helpful
1
Jhan Galvis• 80
@AltairCGS
Posted
@vanzasetia Thank you very much ! I'll keep it in mind <3
1
