Design comparison
Solution retrospective
I leave my contribution to the QR challenge. Apply the picture tag, as one of you had told me in another challenge. I look forward to any feedback from you <3
Use the PerfectPixel tool to make it as similar as possible.
Community feedback
- @vanzasetiaPosted about 2 years ago
Hi, Jhan Galvis! 👋
There's no need to use
picture
element if there's only one version for the image. You only need to usepicture
element when there are many versions for the same image (e.g. three versions of image, mobile, tablet, and desktop).Other than that, everything is looking good as far as the HTML is.
For the styling, I recommend setting
min-height: 100vh
instead ofmin-height: 50rem
. This way, thebody
is always filling the entire page regardless of the user's screen size.I hope this helps! Keep up the good work! 👍
Marked as helpful1@AltairCGSPosted about 2 years ago@vanzasetia Thank you very much ! I'll keep it in mind <3
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord