Skip to content
Submitted almost 2 years ago

QR code component

Jhan Galvis•80
@AltairCGS
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I leave my contribution to the QR challenge. Apply the picture tag, as one of you had told me in another challenge. I look forward to any feedback from you <3

Use the PerfectPixel tool to make it as similar as possible.

Community feedback

  • Vanza Setia•27,775
    @vanzasetiaPosted almost 2 years ago

    Hi, Jhan Galvis! 👋

    There's no need to use picture element if there's only one version for the image. You only need to use picture element when there are many versions for the same image (e.g. three versions of image, mobile, tablet, and desktop).

    Other than that, everything is looking good as far as the HTML is.

    For the styling, I recommend setting min-height: 100vh instead of min-height: 50rem. This way, the body is always filling the entire page regardless of the user's screen size.

    I hope this helps! Keep up the good work! 👍

    Marked as helpful
    1
    Jhan Galvis•80
    @AltairCGSPosted almost 2 years ago

    @vanzasetia Thank you very much ! I'll keep it in mind <3

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord