QR code component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Rio, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add descriptive text in the alt attribute of the images
  • remove all margin from container class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

  Overall you did well 😁 Hope this help!

  Marked as helpful

  1
• 

  P

  MELT•170

  @MeltedGreenVelvetPosted over 2 years ago

  On my monitor, your container is not centered horizontally or vertically, so that's why it's not lining up as it should in the design comparison screenshot. The alignment is significantly off when I visit your preview site. Have you considered utilizing flexbox? I feel that it's so much easier to perfectly and responsively center a container that way, and you'll have more flexibility with other forms of alignment in the future.

  Other than the alignment issue, I feel that your component looks great!!

  Marked as helpful

  1