バレンタイン 😈• 64,190
@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- To properly center your content to your page, you will want to add the following to your
body
element (this method uses CSSFlex
):
body {
min-height: 100vh;
display: flex;
justify-content: center;
align-items: center;
}
More Info:📚
[Centering in CSS][https://moderncss.dev/complete-guide-to-centering-in-css/]
- Apply the background color to the
body
to have it take up the entire screen.
- The incorrect
font-family
is being used. You want to look at your "style-guide" to download the correct one.
- To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the
main
element.
More Info:📚
- Remove the
height
from your component's container, it is not needed.
- The “QR image” needs to have an Alt Tag. Its needs to tell screen reader users what it is and where it will take them to when they scan it.
- Change
width
tomax-width: 100%
in your image to make it responsive. You will also want to remove theheight
as it is unnecessary.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
0