@Alex-Archer-I
Posted
Hi!
Congrats with your first challenge. It's quite a neat and accurate work =)
The main
tag and semantic tags at all have a very wide browser support now, so there is no need to use role attribute. It's preferable to use tag where it's possible.
To make your elements more responsive you can use max-width
property.
.qr-code {
max-width: 320px;
}
Or in combination with the width
:
.qr-code {
width: 95%;
max-width: 320px;
In both cases .qr-code
element will keep 320px
until the screen become smaller. Than it'll take 100%
or 95%
from the screen. It isn't necessary in this project as mobile version designed for 375px
screens, but will be useful in future.
Well, hope that helps. Good luck =)
Marked as helpful
@DylandeBruijn
Posted
@Alex-Archer-I
Thanks a lot for taking the time and providing me with valuable feedback Alex!
@Alex-Archer-I
Posted
@DylandeBruijn
You're welcome. Feel free to ask or comment anything if need =)