Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

Paul 70

@Paulanthonyrocks

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Travolgi 🍕 31,400

@denielden

Posted

Hi Paul, great work on this challenge! 😉

Here are a few tips for improve your code:

  • it is a good idea to write the names of all files and folders in lowercase, apart from in certain cases such as in React projects
  • fix the links to the css sheet and the image because they are broken like this: <link rel="stylesheet" type="text/css" href="./QR CODE/Assets/CSS/Style.css"> and <img class="image" alt="" src="./QR CODE/Assets/Images/image-qr-code.png">
  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • to make it look as close to the design as possible add width: 20rem to barcode-wrapper class
  • remove all margin from barcode-wrapper class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

Overall you did well 😁 Hope this help!

Marked as helpful

0

Paul 70

@Paulanthonyrocks

Posted

@denielden thanks, would do!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord