QR code component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Paul, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • it is a good idea to write the names of all files and folders in lowercase, apart from in certain cases such as in React projects
  • fix the links to the css sheet and the image because they are broken like this: <link rel="stylesheet" type="text/css" href="./QR CODE/Assets/CSS/Style.css"> and <img class="image" alt="" src="./QR CODE/Assets/Images/image-qr-code.png">
  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • to make it look as close to the design as possible add width: 20rem to barcode-wrapper class
  • remove all margin from barcode-wrapper class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  Marked as helpful

  0

  ---

  

  Paul•70

  @PaulanthonyrocksPosted over 2 years ago

  @denielden thanks, would do!

  1