QR code component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello 👋. Congratulation on successfully completing your first challenge 🎉 ! !

  I have some recommendations regarding your code that I believe will be of great interest to you.

  • All the content that you had inside the frontend.html file should be placed inside index.html.

    When a user types a URL into their browser, the browser sends a request for the resource at that URL. later, the server will look for a default file to serve in that directory. By convention, the default file is named index.html.

  HTML 🏷️:

  • Wrap the page's whole main content in the <main> tag.

  • Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy. Source 📘

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource 📘.

  • Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  0

  ---

  

  MortalCoder•180

  @mortalcodePosted almost 2 years ago

  @MelvinAguilar Thanks for the feed back, have implemented these tips in my new project ( Product Preview https://www.frontendmentor.io/solutions/product-preview-page-KjTyN5jg5t ), learning new things Everyday!

  0