Skip to content
Submitted about 2 years ago

QR code component

Amulya Prakash•800
@amulyalovescoding
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi, All feedback is welcome. Thanks

Community feedback

  • Gelcimar Moraes•150
    @GelcimarMoraesPosted about 2 years ago

    Hi, @amulyalovescoding Congratulations on finishing this project.

    I really liked the result of your project, but I have some tips that I think you will like:

    Accessibility

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    Marked as helpful
    1
    Amulya Prakash•800
    @amulyalovescodingPosted about 2 years ago

    Hi, @GelcimarMoraes Thanks for providing me valuable tips, I will surely implement from now on.

    Please don’t hesitate to guide me again. Thanks again for giving me this information.

    1
  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello Amulya Prakash, Congratulations on completing this challenge!

    Nice code and nice solution! You did a good job here putting everything together. I’ve some suggestions for you:

    Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    <body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    0
    Amulya Prakash•800
    @amulyalovescodingPosted about 2 years ago

    Thanks @correlucas for suggesting cleaning unnecessary <div>.

    I have implemented it & it's really worked out.

    Thanks Again 😊

    1
    Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    @amulyalovescoding this is nice. I am happy to hear that, I hope this was useful and helped u to improve it. Keep posting amazing content

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord