QR Code Component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hey Steven, congratulations on completing the challenge! You did a great job 😉

  Let me give you some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • not use inline style inside html... styling the body into css stylesheet and remove width property
  • add descriptive text in the alt attribute of the images
  • use h1 tag instead of a div for the title of card
  • use p tag instead of a div for the text of card
  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • remove all margin from white-border class because with flex they are superfluous
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😁

  0