Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

@dhruvjha206

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Dan 300

@dtp27

Posted

Hi @dhruvjha206!

Congrats on your first challenge, and welcome to Frontend Mentor! A few recommendations I have on your solution:

  1. I would use another p instead of span so that it's treated like a block component in normal flow instead of an inline component.
  2. It's good that you're using Flexbox to center, but I would add flex-direction: column; to make sure that the card and footer are stacked vertically instead of horizontally.
  3. For the img width, I would use max-width: 100%; so that it responsively adjusts to screen size.
  4. It also seems like you hard-coded the width .container to 1440px, which is the total width of the page the design is at. Instead, I would play around with % for the width of the .container, which will make the card responsively adjust.

Let me know if you have any questions.

Happy coding!

Dan

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord