QR code component

Hello there 👋. Good job on completing the challenge !

I have other suggestions about your code that might interest you.

HTML 📄:

• Wrap the page's whole main content in the <main> tag.

• Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy. Source 📘

Alt text 📷:

• The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

  If you want to learn more about the alt attribute, you can read this article. 📘.

I hope you find it useful! 😄

Happy coding!

Replace <div class="card"> with the main tag and <h3> with <h1> to fix the accessibility issue. click here for more on web-accessibility and semantic html

The body has a wrong background-color. Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

To center .card on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

To center .card on the page using flexbox:
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}

To center .card on the page using grid:
body{
min-height: 100vh;
display: grid;
place-items: center;
}

Increase the padding a width value of .card for it to be equivalent to the width of the design. width:320px padding: 15px

Give h1 and p the same font-size of 15px, text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING