QR code component

Community feedback

• 

  Mikołaj Kasperkiewicz•70

  @PanMikolajPosted over 2 years ago

  Hi!

  To get rid of accessiblity issues you should change your main <div> to <main>

  <main> works just the same as <div> but it is clearer to see the use of it.

  In addition you should get rid of <div class="attribution"> and put text that was inisde to another <p> that will be at the bottom of <main>. In my opinion it's just looks better.

  You should also change <h2> to <h1> and bold your <p> with this whole "scan text". <p>Scan the QR code to...</p>

  If u want to see what i meant go check my own solution for this challenge: https://www.frontendmentor.io/solutions/qr-code-component-qgm4m_84z

  Remember that I'm also a newbie and this is just my opinion on aesthetics.

  Good luck and have fun with other projects!

  Marked as helpful

  0