QR code component

Community feedback

• 

  Marzuk Sanni•1,360

  @ZukizukPosted 10 months ago

  Hello @Kennedy

  Your solution looks amazing. Congratulation on completing your first frontend mentor challenge.

  I have few suggestion that I think might interest you on this solution.

  First of all, It is merely a suggestion on my part but I think you should have used just HTML CSS instead of Angular to build this project since it doesn't require Data bindings or anything of that sort which makes using Angular kind of a stretch and may introduce unnecessary complexity and potentially impact performance.

  Also consider using semantic html like main and header tags instead of div. Example. Consider using <main></main> for the div element have container class.

  Now concerning your question. I think you did a great job with the media queries, but you can try using relative unit like rem and em instead of px and also doing mobile first and using media queries for the desktop version but you can do however you are comfortable with.

  I hope this feedback helps

  Marked as helpful

  0

  ---

  

  Tokelo•150

  @Kennedy-was-takenPosted 10 months ago

  Hello @Zukizuk

  Thank you so much for your feed back. it really is helpful and I'll take your advice to help.

  The reason why I used Angular was because I wanted an excess to practice using angular so it becomes second nature by the time I want to introduce data-binding, navigation etc etc. So the plan was to tackle two bird with one stone. So when the time comes, the amount of time researching angular on how certain components work will be far less compared to the first time around.

  I'll update my solution based on your recommendation and remove px and div.

  Once again, thank you for the advice

  0

  

  Marzuk Sanni•1,360

  @ZukizukPosted 10 months ago

  @Kennedy-was-taken

  I understand and I am happy my feedback was helpful to you. Good luck!

  0

  

  Marzuk Sanni•1,360

  @ZukizukPosted 10 months ago

  @Kennedy-was-taken

  I understand and I am happy my feedback was helpful to you. Good luck!

  0