qr-code-component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • The <br> tag is not a semantic element. If a screen reader user is reading the page, they will hear "line break", which breaks the flow of the content. Instead, use CSS properties like margin and padding to add vertical space between elements.

  Alt text 📷:

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  CSS 🎨:

  • Use a max-width for the component. The max-width property is used to set the maximum width of an element. It prevents the element from becoming larger than the specified value, even if a larger width is specified in the CSS.

  .qr__component {
      /* width: auto; */
      /* height: auto; */
      max-width: 450px; /* Value of example*/
       . . . 
  }
  

  • To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📘.

  body {
      min-height: 100vh;
      display: flex;
      align-items: center;
      justify-content: center;
      flex-direction: column;
  }
  
  @media screen and (min-width: 1440px)
  body {
      /* padding: 5% 25%; */ /* Remove this, use flexbox to center*/
  }
  

  • You should use a CSS reset to remove the default browser styles and make your page look the same in all browsers.

    Popular CSS resets:

    • Normalize.css
    • Reset CSS
    • "My Custom CSS Reset" by JoshWComeau

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  rymxoxo•60

  @rymxoxoPosted almost 2 years ago

  @MelvinAguilar Amazing feedback , thank you so much for the advices

  1

  

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  @rymxoxo You're welcome!

  0
• 

  Sachin•830

  @Sachin-MahatoPosted almost 2 years ago

  read the accessibility report.

  0

  ---

  

  rymxoxo•60

  @rymxoxoPosted almost 2 years ago

  @Sachin0000000 thank you i'll check it out

  0