QR Code Component

Community feedback

• 

  Yash Joshi•450

  @yashgjoshi20Posted over 1 year ago

  Hey well done for completed this challenge😁

  I have some suggestions to help you to improve your solution :

  1. You should put the <div class="attribution"> outside the <main> tag
  2. then replace the <div> tag by semantic tag <footer>
  3. footer can contain informations about author, copyright etc

  HTML :

  <main>
  </main>
  
  <footer class="attribution">
  </footer>
  

  I also make pull requests on your Github repo so you can merge it if the changes suit you

  I hope you'll find this helpful, and your solutions is really good 😁

  Marked as helpful

  1
• 

  Ankit•40

  @fabledankitPosted over 1 year ago

  I looked at the font size provided for the paragraph, and look at how it was wrapped in the container. Now resize the container until it wraps the way it did in the design. That's how I did it. Hope it helps 👍

  1
• 

  Bader Idris•2,880

  @Bader-IdrisPosted over 1 year ago

  You can set the container in the middle of the screen whatever user changes it when you add these properties to it in CSS:

  .container {
    position: absolute;
    top:50%;
    left: 50%;
    transform: translate(-50%, -50%);
  }
  

  the new feature is transform, it has many lovely properties you can discover, I personally love it. Hope it's useful

  1