Design comparison
SolutionDesign
Solution retrospective
Starting with the QR code component challenge. I dabbled a bit with box shadows on this project.
Any feedback on improvements is appreciated. Thanks!
Community feedback
- @vanzasetiaPosted almost 2 years ago
Hi, Siva! 👋
I have some recommendations to improve this solution.
- Merge the four CSS files into one file. It makes the website slower because it creates four requests to the server. So, only use one CSS file whenever possible.
- Remove the
<picture>
element. Only use it when there is multiple version of the image. - Alternative text should not be hyphenated like class names. It should be human-readable.
- Replace the
<h3>
with<h1>
. Start using heading tags from<h1>
to<h6>
.
I hope this helps. Happy holidays!
Marked as helpful2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord