QR code using flexbox

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Eduard, You have done a good work! 😁

  Some little tips to improve your code:

  • you can use article tag instead of a simple div to the container card for improve the Accessibility
  • use class to style the element and not id because the ids must be unique in all the page
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  0
• 

  Adriano•38,330

  @AdrianoEscarabotePosted almost 2 years ago

  Hello Eduard Ionescu, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

  To improve the responsiveness of the project, we can make some changes:

  main div.container {
      max-width: 375px;
  }
  

  Instead of using "width" to specify an absolute width, use "max-width" to specify a maximum instead. By doing this, the content will behave much more amiably in smaller resolutions, making it easier to make the project responsive.

  The remainder is excellent.

  I hope it's useful. 👍

  0