QR Code Challenge Solution

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  • The width: 100% property in the body tag is not necessary. The body tag is a block element and it will take the full width of the page by default.

  • Use min-height: 100vh instead of height: 100vh. The height property will not work if the content of the page grows beyond the height of the viewport.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding! 🎄**

  Marked as helpful

  2

  ---

  

  Lucas Richard Garcia Tinoco•50

  @lucasrgtPosted almost 2 years ago

  @MelvinAguilar thanks for the comment! i'll do my best to improve :D

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="container__card"> with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/

  There is no need to give the body a width value. there is no need to give img and .container__text display: flex and its properties.

  Give .container__card a fixed max-width value instead of a percentage width, e.g: .container__card { max-width: 320px;}

  Hope am helpful. Happy coding

  Marked as helpful

  1

  ---

  

  Lucas Richard Garcia Tinoco•50

  @lucasrgtPosted almost 2 years ago

  @Hassiai thanks for your reply, i'll improve my code!

  0