QR code component | Vanilla CSS - BEM

Community feedback

• 

  khushboo khatwani•1,070

  @khushi0909Posted over 1 year ago

  1. i find the content big as compared to the expected design

  2)Read about h1 tag its the most important and every website should have atleast one https://www.semrush.com/blog/h1-tag/

  3)now it looks good on every screen ,but you can read about media queries for responsiveness for the future

  All the best

  Marked as helpful

  0

  ---

  

  Víctor Iván López•100

  @victorivanlopezlearningPosted over 1 year ago

  @khushi0909 Thanks for the feedback!

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  QR iMAGE ALT TEXT 📸:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.

  ---

  • The alt with Image QR is not even explaining for what the QR image need to be used.

  ---

  • So update the alt with meaningful text which explains like QR code to frontendmentor.io

  ---

  • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Víctor Iván López•100

  @victorivanlopezlearningPosted over 1 year ago

  @0xAbdulKhalid Thanks for your recommendation!

  0