QR Code Component Solution

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge !

  I have some feedback for you if you want to improve your code.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding and Happy New Year! 🎉🎊🎁

  1
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size. The rem unit is relative to the browser and can be changed by the user, the em unit is relative to the first font-size. for more on CSS units click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0