Submitted over 1 year ago

QR Code Component

Phanindra• 50

@phanindra28

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Community feedback

Abdul Khaliq 🚀• 72,660

@0xabdulkhaliq

Posted over 1 year ago

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

CSS MEASUREMENTS 📐:

Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh.

But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

Phanindra• 50

@phanindra28

Posted over 1 year ago

@0xAbdulKhalid Thanks a lot for the explanation on the min-height concept! Will definitely try incorporating them.

Sumanth Chandana• 720

@sumanth-chandana

Posted over 1 year ago

Hi Phanindra!, congrats🎉 on completing the challenge. Better take care about following points.

Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings.
Use the alt (alternate text) attribute as mentioned in your Accessibility Report. alt attribute is used for Screen readers applications.
Why does alt attribute matter? Read here.
To avoid accessibility issues "All page content should be contained by landmarks" use code as :

 <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

(why does <main> matter? Read here )

For proper centering the container(whole card) vertically and horizontally you can also use the following simple block of code use code:

body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}

When we open the GitHub repository link, you will find an About Section on the right side. There, also include a live preview link of your project. It is better for someone to check your live project while interacting with code.

I hope you will find this Feedback Helpful.

Marked as helpful

Phanindra• 50

@phanindra28

Posted over 1 year ago

@sumanth-chandana Thanks a lot for the insights! Will definitely try incorporating them.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord