Skip to content
Submitted almost 2 years ago

QR Code compartment - desktop version

Haein Yoo•20
@haeiny95
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

First try at QR Code compartment project.

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted almost 2 years ago

    Hello there 👋. Good job on completing the challenge !

    I have some suggestions about your code that might interest you.

    There is no need to maintain the previous code, GitHub is a version control, which means it allows developers to track changes made to their code.

    HTML 📄:

    • The viewport meta tag is missing. the viewport meta tag is used to control the layout of the page on mobile devices. Add the viewport meta tag to the <head> tag: <meta name="viewport" content="width=device-width, initial-scale=1.0">
    • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
    • The alt attribute would be QR code to frontendmentor.io

    CSS 🎨:

    • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here 📘.
    • Use min-height: 100vh instead of height: 100vh. The height property will not work if the content of the page grows beyond the height of the viewport.

    I hope you find it useful! 😄

    Happy coding!

    1
  • Christine•70
    @christinepallonPosted almost 2 years ago

    Great job on completing your first project!

    As you move forward, you should consider using relative values (such as rem or em) for sizing, margin, padding, etc instead of using PX, which is absolute. Doing so will make things a lot easier as you you start working on responsive projects! Here's a link that might be helpful: https://www.freecodecamp.org/news/absolute-and-relative-css-units/

    Happy coding!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord