Melvin Aguilar 🧑🏻💻• 61,220
@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
There is no need to maintain the previous code, GitHub is a version control, which means it allows developers to track changes made to their code.
HTML 📄:
- The
viewportmeta tag is missing. theviewportmeta tag is used to control the layout of the page on mobile devices. Add theviewportmeta tag to the<head>tag:<meta name="viewport" content="width=device-width, initial-scale=1.0">
- Use the
<main>tag to wrap all the main content of the page instead of the<div>tag. With this semantic element you can improve the accessibility of your page.
- The
altattribute would beQR code to frontendmentor.io
CSS 🎨:
- Instead of using pixels in font-size, use relative units like
emorrem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here 📘.
- Use
min-height: 100vhinstead ofheight: 100vh. Theheightproperty will not work if the content of the page grows beyond the height of the viewport.
I hope you find it useful! 😄
Happy coding!
1
