Simple html,css webpage

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="one"> with the main tag<main> and the first <p> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  There is no need to give the body and html a width and height value. To center .one on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center .one on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center .one on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  There is no need to give .one a height value and a margin value. Replace the height value with a padding value for all the sides. padding: 15px. give the img a max-width of 100% instead of a width and height value. There is no need to give the img a padding value.

  Give h1 and p the same font-size of 15px, the same margin-left, margin-right and margin-top values. give p a margin bottom value. there is no need to give p and h1 a font- weight value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  parvesh-rana•10

  @parvesh-ranaPosted almost 2 years ago

  @Hassiai ThankYou for feedback. Appreciate Your help.

  0