Interactive and cool looking QR code component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  • The text Improve Your Front-End Skills by Building Projects is considered a heading element (h1).

  • It might be more efficient to use the <p> tag; the <p> element represents paragraph-level content, usually text:

  <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
  

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here 📘.

  • Use min-height: 100vh instead of height: 100vh. The height property will not work if the content of the page grows beyond the height of the viewport.

  I hope you find it useful! 😄

  Happy coding!

  0

  ---

  

  Md Alqma Ansari•40

  @Md-AlqmaPosted almost 2 years ago

  @MelvinAguilar Thank you so much for your valuable feedback. I will definitely work on that. It is of great help and I will keep all these points in mind for furure.

  1