QR code component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  you gave the closing tag of <h1> </h3> instead of </h1> and your CSS you mention h3 instead of h1 in p, h3 . i think you forgot. There is no need to give the body a width value and the img a height value. There is no need to give h1 a font-size , give p a font-size of 15px .

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To

  Hope am helpful.

  Well done for completing this challenge. Happy coding

  Marked as helpful

  1

  ---

  

  Josue David Lopez Florian•180

  @JUMPSTONIKPosted almost 2 years ago

  @Hassiai Thank you so much for all your suggestions. I already did all the changes and now is better. Now I know what I dont have to do in my next projects.

  0
• 

  Bentaher malek•730

  @malek-btPosted almost 2 years ago

  Hi 👋, good job completing this challenge ! 🎉

  I have some suggestions you might consider to improve your code:

  1. You should make sure that the open tag are the same the close tag (<h1></h1>).

  2.The <img> alt attribute is used to specify the alternate text for an image. It is useful when the image is not displayed. It is used to give alternative information for an image.So make sure to make it not empty.

  I hope those tips will help you! 👍

  IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL 🤩

  Good job, and happy coding! 😁

  Marked as helpful

  1

  ---

  

  Josue David Lopez Florian•180

  @JUMPSTONIKPosted almost 2 years ago

  @malek-bt Thanks Bentaher. I added some text to the alt attribute and change the error I had with the h1 tag.

  1