Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

Sabira K. 80

@hello-sabira

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are some bad practices you see in my code that I should improve on? Thanks!

Community feedback

Hassia Issah 50,670

@Hassiai

Posted

Replace <h3> with <h1> to fix the accessibility issue

give .qr-info a padding value for all the sides, instead of giving p and h1 a padding value. either give p a margin-top value or h1 a margin bottom value for the space between the text.

Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

1

Sabira K. 80

@hello-sabira

Posted

@Hassiai Hello, thanks a lot for the detailed feedback, truly appreciate it :))

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord