QR code component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <h3> with <h1> to fix the accessibility issue

  give .qr-info a padding value for all the sides, instead of giving p and h1 a padding value. either give p a margin-top value or h1 a margin bottom value for the space between the text.

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Sabira K.•80

  @hello-sabiraPosted almost 2 years ago

  @Hassiai Hello, thanks a lot for the detailed feedback, truly appreciate it :))

  0