Design comparison
Solution retrospective
What did you find difficult while building the project? I tended to overthink and this has showed me little is more. Which areas of your code are you unsure of? Laying out sections in html (<sections> <header> <div> <article>) Do you have any questions about best practices? When you first start on a project, do y'all start organizing your CSS or Basic HTML layout?
Community feedback
- @HassiaiPosted over 1 year ago
To center .container on the page using flexbox or grid instead of a margin, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
To center .container on the page using flexbox: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
To center .container on the page using grid: body{ min-height: 100vh; display: grid; place-items: center; }
Replace the height in .container with a padding value for all the sides, this will prevent the content from overflowing on smaller screens and its a responsive replacement.
padding: 16px
Give the img a max-width of 100% instead of a width for a responsive image.
There is no need for a media query in this challenge because you gave .container a fixed max-width value.
Give .text a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord