QR code component

Community feedback

• 

  geomydas•1,400

  @geomydasPosted about 2 months ago

  Hi @jboys, I have recently just finished reading your code and it looks good but it has some few issues

  1. Apply the styles of the first div in the body element. No need to use a wrapper div here
  2. Don't set fixed widths such as w-80 or h-96. Doing so will prevent the element from shrinking causing unresponsivness and overflow issues. Try max-w-80 paired with w-full instead.
  3. Remove the third wrapper div and apply the paddings on the second wrapper div itself
  4. Remove the wrapper div that contains the heading and the paragraph. You can just apply the m-t on the heading. There is no need for the padding for both of the elements and you can just directly apply the padding on the paragraph element.
  5. Consider self hosting your fonts. Using google fonts and linking their API is slower since you still have to connect to an external server plus it is also a privacy issue as it breaks GDPR. I use this handy tool for helping me self host the fonts.
  6. Add the colors provided in the style-guide.md file inside your tailwind.config.js instead of using the pre-made color palette provided by Tailwind in order to follow the design

  That's all and don't be overwhelmed. You can do one bullet at a time. Have a nice day and have fun coding!

  Marked as helpful

  0